backend: handle no_mangle attribute #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philberty
requested changes
Apr 22, 2022
liushuyu
force-pushed
the
attr-add-no-mangle
branch
from
9ce1fbc
to
f4db42d
Compare
philberty
reviewed
Apr 22, 2022
|
|
||
| namespace Rust { | ||
| namespace Compile { | ||
|
|
||
| bool inline should_mangle_item (const tree fndecl) | ||
| { | ||
| return lookup_attribute ("no_mangle", DECL_ATTRIBUTES (fndecl)) == NULL_TREE; |
There was a problem hiding this comment.
I really like how you did this to split up the logic.
I guess the GCC idiom would be that this should be a macro called SHOULD_MANGLE_ITEM_P and put it over in rust-tree.h not sure what design I want in the code-generation part at the moment so lets stick with this for now.
There was a problem hiding this comment.
I really like how you did this to split up the logic.
I guess the GCC idiom would be that this should be a macro called SHOULD_MANGLE_ITEM_P and put it over in rust-tree.h not sure what design I want in the code-generation part at the moment so lets stick with this for now.
Noted. I will keep this in mind in the near future.
Imports and Visbility
automation
moved this from Review in progress
to Reviewer approved
Apr 22, 2022
liushuyu
force-pushed
the
attr-add-no-mangle
branch
from
f4db42d
to
a969ab6
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no_mangleattribute