Add unit-type support for Identifier expressions #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the to_string for type kind will improve the debug message for type wrappers.
struct S; Turns into an ADT type which is a type of unit-struct.
IdentifierExpr's can reference types like a unit-struct, referencing other structs actually form a function item type which is not supported yet.
CohenArthur
approved these changes
Jun 25, 2021
Comment on lines
+4
to
+5
| let s = S; | ||
| // { dg-warning "unused name" "" { target *-*-* } .-1 } |
There was a problem hiding this comment.
nit: If you don't care about the warning you can also use let _s = S; since that's working now
Rust supports unit struct initilization such as S{} this takes this tree
and resolves it fully. This should really be all desugared via HIR but that
is in progress in another PR.
|
bors r+ |
|
Build succeeded: |
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this pull request
Nov 7, 2023
Fixes: 3496ca4 ("RISC-V: Add runtime invariant support") riscv_promote_function_mode doesn't promote a SI to DI for libcalls case. It intends to do that however the code is broken (regression). The fix is what generic promote_mode () in explow.cc does. I really don't understand why the old code didn't work, but stepping thru the debugger shows old code didn't and fixed does. This showed up when testing Ajit's REE ABI extension series which probes the ABI (using a NULL tree type) and ends up hitting the libcall code path. gcc/ChangeLog: * config/riscv/riscv.cc (riscv_promote_function_mode): Fix mode returned for libcall case. Tested-by: Patrick O'Neill <patrick@rivosinc.com> # pre-commit-CI Rust-GCC#526 Signed-off-by: Vineet Gupta <vineetg@rivosinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit type can be reference via an identifier expression. Other type references via an identifier expression are not supported yet.