Change incorrectly typed enums to bitflags in audio_format module. Increment version to 0.3 for breaking changes. #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/audio_unit/audio_format.rs
Outdated
There was a problem hiding this comment.
I have no idea HOW I spotted this, but there's a slight capitalization error; should be MIDIPacketList, not MIDIPAcketList
|
I'm done going over these changes; great stuff! After the notes I added are addressed I'm happy with this being merged 👍 |
Member
Author
|
Haha amazing hawk-eye typo review 👍 Just committed the fixes, will merge and publish! |
mitchmindtree
added a commit
that referenced
this pull request
Nov 11, 2015
Change incorrectly typed enums to bitflags in audio_format module. Increment version to 0.3 for breaking changes.
Member
Author
|
Published as 0.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yupferris does this look good to you? I'm about to go for coffee, but were there any other types that needed bitflag-ification? If so, I can add them to this PR. Otherwise if there are no issues, feel free to merge and publish this.