Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method with_sample_rate uses max sample rate #461

Closed
AlexanderHarrison opened this issue Jul 29, 2020 · 2 comments
Closed

Method with_sample_rate uses max sample rate #461

AlexanderHarrison opened this issue Jul 29, 2020 · 2 comments
Labels
bug

Comments

@AlexanderHarrison
Copy link
Contributor

Method with_sample_rate on SupportedStreamConfigRange does not use given sample rate, but the max sample rate instead.
@italic-r
Copy link

I also see this issue, and the linked patch does make cpal return a StreamConfig with the right sample rate, but I have not tested it with a stream yet.

Just chiming in to say I have come across this, too.

mitchmindtree added a commit that referenced this issue Aug 2, 2020
@mitchmindtree
Merge pull request #462 from AlexanderHarrison/master
bfffbb5 
Fix issue #461
@mitchmindtree
Copy link
Member

Thank you both! Closing now that #462 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@italic-r @mitchmindtree @AlexanderHarrison