Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running "cargo fmt" and improving Plugin::instantiate #2

Merged
merged 1 commit into from Apr 29, 2019

Conversation

@Janonard
Copy link
Member

Janonard commented Apr 29, 2019

My main goal is to improve the Plugin::instantiate implementation: First, information like the frame rate, the bundle path or the URI of the plugin should be passed to the plugin. Therefore, I needed to extend the trait as well as the Plugin::instantiate implementation; Both reside in lv2-core/src/plugin/plugin.rs. While I was at it, I also updated the error management: In short, you already did the right thing: If the plugin can't be instantiated, the instantiate method should simply return a null pointer, that's expected behavior (as noted in the spec).

Lastly, I accidentally ran cargo fmt. It did a lot of things, but I don't think that having consistent code formatting is a bad thing, isn't it?

@Janonard Janonard requested a review from prokopyl Apr 29, 2019
@prokopyl

This comment has been minimized.

Copy link
Contributor

prokopyl commented Apr 29, 2019

This all looks great to me!

And cargo fmt is something I wanted to do anyways, i just still have to integrate in more properly in my development workflow. ^^

@prokopyl prokopyl merged commit a68b177 into RustAudio:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.