This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Change signature of get_mut method on Outputs to fix unsafety bug
#108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PieterPenninckx
commented
Nov 2, 2019
| unsafe { slice::from_raw_parts(self.bufs[i], self.samples) } | ||
| } | ||
|
|
||
| /// Mutably access channel at the given index, unchecked |
Contributor
Author
There was a problem hiding this comment.
I'm not sure why the documentation states "unchecked" (same for the get method).
Contributor
There was a problem hiding this comment.
Indeed. With the types in place, there doesn't seem to be anything unchecked about this. Giving an out-of-bounds index will panic, as it should.
Same thing goes for get in Inputs.
askeksa
approved these changes
Nov 3, 2019
Contributor
askeksa
left a comment
askeksa
left a comment
There was a problem hiding this comment.
Change looks good. I suggest removing , unchecked in the three places it occurs.
| unsafe { slice::from_raw_parts(self.bufs[i], self.samples) } | ||
| } | ||
|
|
||
| /// Mutably access channel at the given index, unchecked |
Contributor
There was a problem hiding this comment.
Indeed. With the types in place, there doesn't seem to be anything unchecked about this. Giving an out-of-bounds index will panic, as it should.
Same thing goes for get in Inputs.
askeksa
pushed a commit
that referenced
this pull request
Nov 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73.