From 7bfb327d964812ffdebeb8b12bebbf2c4941cd6c Mon Sep 17 00:00:00 2001 From: Artyom Pavlov Date: Mon, 7 Aug 2023 16:34:46 +0300 Subject: [PATCH] Update Clippy and fix lints (#49) --- .github/workflows/workspace.yml | 2 +- Cargo.lock | 12 ++++++------ cfb-mode/tests/aes.rs | 10 +++++----- cfb8/tests/aes.rs | 4 ++-- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/.github/workflows/workspace.yml b/.github/workflows/workspace.yml index 4c36020..b1a8770 100644 --- a/.github/workflows/workspace.yml +++ b/.github/workflows/workspace.yml @@ -17,7 +17,7 @@ jobs: - uses: RustCrypto/actions/cargo-cache@master - uses: dtolnay/rust-toolchain@master with: - toolchain: 1.56.0 # MSRV + toolchain: 1.71.0 components: clippy - run: cargo clippy --all --all-features -- -D warnings diff --git a/Cargo.lock b/Cargo.lock index e7e3784..3495ac3 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -94,9 +94,9 @@ dependencies = [ [[package]] name = "cpufeatures" -version = "0.2.8" +version = "0.2.9" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "03e69e28e9f7f77debdedbaafa2866e1de9ba56df55a8bd7cfc724c25a09987c" +checksum = "a17b76ff3a4162b0b27f354a0c87015ddad39d35f9c0c36607a3bdd175dde1f1" dependencies = [ "libc", ] @@ -165,18 +165,18 @@ dependencies = [ [[package]] name = "kuznyechik" -version = "0.8.1" +version = "0.8.2" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "8483b65417c9aca2348085fecc5eaef5af04834190b329dddd90f562204e632b" +checksum = "ca7899a524198c60ded686fc826703de2a04470aff9d042e8cc1f845b912c12f" dependencies = [ "cipher", ] [[package]] name = "libc" -version = "0.2.146" +version = "0.2.147" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "f92be4933c13fd498862a9e02a3055f8a8d9c039ce33db97306fd5a6caa7f29b" +checksum = "b4668fb0ea861c1df094127ac5f1da3409a82116a4ba74fca2e58ef927159bb3" [[package]] name = "magma" diff --git a/cfb-mode/tests/aes.rs b/cfb-mode/tests/aes.rs index 188ea47..e0eccf7 100644 --- a/cfb-mode/tests/aes.rs +++ b/cfb-mode/tests/aes.rs @@ -39,11 +39,11 @@ fn aes128_cfb_async_test() { *b = (i % 11) as u8; } let enc = Enc::new_from_slices(&key, &iv).unwrap(); - let mut ct = pt.clone(); + let mut ct = pt; enc.encrypt(&mut ct); for i in 1..100 { let enc = Enc::new_from_slices(&key, &iv).unwrap(); - let mut t = pt.clone(); + let mut t = pt; let t = &mut t[..i]; enc.encrypt(t); assert_eq!(t, &ct[..i]); @@ -72,13 +72,13 @@ fn aes128_cfb_buffered_test() { // unbuffered let enc = Enc::new_from_slices(&key, &iv).unwrap(); - let mut ct = pt.clone(); + let mut ct = pt; enc.encrypt(&mut ct); // buffered for i in 1..100 { let mut buf_enc = BufEnc::new_from_slices(&key, &iv).unwrap(); - let mut ct2 = pt.clone(); + let mut ct2 = pt; for chunk in ct2.chunks_mut(i) { buf_enc.encrypt(chunk); } @@ -94,7 +94,7 @@ fn aes128_cfb_buffered_test() { // buffered with restore for i in 1..100 { let mut buf_enc = BufEnc::new_from_slices(&key, &iv).unwrap(); - let mut ct2 = pt.clone(); + let mut ct2 = pt; for chunk in ct2.chunks_mut(i) { let (iv, pos) = buf_enc.get_state(); let cipher = Aes128::new_from_slice(&key).unwrap(); diff --git a/cfb8/tests/aes.rs b/cfb8/tests/aes.rs index f1f7ab9..4546a89 100644 --- a/cfb8/tests/aes.rs +++ b/cfb8/tests/aes.rs @@ -39,11 +39,11 @@ fn aes128_cfb8_async_test() { *b = (i % 11) as u8; } let enc = Enc::new_from_slices(&key, &iv).unwrap(); - let mut ct = pt.clone(); + let mut ct = pt; enc.encrypt(&mut ct); for i in 1..100 { let enc = Enc::new_from_slices(&key, &iv).unwrap(); - let mut t = pt.clone(); + let mut t = pt; let t = &mut t[..i]; enc.encrypt(t); assert_eq!(t, &ct[..i]);