Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release sha2 v0.9.7 #313

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Release sha2 v0.9.7 #313

merged 1 commit into from
Sep 8, 2021

Conversation

newpavlov
Copy link
Member

No description provided.

@newpavlov newpavlov merged commit 726e3c3 into master Sep 8, 2021
@newpavlov newpavlov deleted the release/sha2-v0.9.7 branch September 8, 2021 17:41
@jplatte
Copy link

jplatte commented Sep 9, 2021

@newpavlov @tarcieri This release broke Sha384, please yank!

I created a minimal reproduction as a private repo and invited you both to see it. It might only affect some inputs (there is a working test for sha384 in this repo afterall). This breakage was brought to my attention in SQLx'es Discord (not sure whether this link works) because SQLx hashes migration scripts to make sure exactly that migration was applied.

@tarcieri
Copy link
Member

tarcieri commented Sep 9, 2021

I've gone ahead and yanked this out of caution.

I will investigate and see if I can reproduce the problem. If I can, I'll file a @rustsec advisory.

@newpavlov
Copy link
Member Author

Oh, sorry about that!

force-soft works without issues and you don't use the asm feature, correct?

cc @Rexagon

@tarcieri
Copy link
Member

tarcieri commented Sep 9, 2021

FWIW I wasn't able to reproduce this problem

@newpavlov
Copy link
Member Author

@tarcieri
Just to be sure: are you running it on an x86-64 CPU with AVX2?

@tarcieri
Copy link
Member

tarcieri commented Sep 9, 2021

Yes, Intel Core i9

@newpavlov
Copy link
Member Author

I was able to reproduce this bug. Looks like there is a problem in the AVX2 part. If we are processing blocks one by one, then the AVX code works correctly.

@tarcieri
Copy link
Member

tarcieri commented Sep 9, 2021

Aah, it's possible the input message I used to test wasn't long enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants