Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elliptic-curve: revised LinearCombination trait #835

Merged
merged 1 commit into from
Dec 4, 2021

Conversation

tarcieri
Copy link
Member

@tarcieri tarcieri commented Dec 4, 2021

Changes LinearCombination to be impl'd on the ProjectivePoint type for a given curve, rather than the curve ZST.

This better fits the trait-based structure used by the group crate, and also makes sense as ProjectivePoint is the return type, so it's almost certain to be in scope (as opposed to importing a curve ZST to do the operation)

This is technically a breaking change as the LinearCombination trait was just released an hour ago in v0.11.4, but given that it's unlikely anyone is using it yet, so it can probably be safely yanked and the updated version included in a new release.

Changes `LinearCombination` to be impl'd on the `ProjectivePoint` type
for a given curve, rather than the curve ZST.

This better fits the trait-based structure used by the `group` crate,
and also makes sense as `ProjectivePoint` is the return type, so it's
almost certain to be in scope (as opposed to importing a curve ZST to do
the operation)

This is technically a breaking change as the `LinearCombination` trait
was just released an hour ago in v0.11.4, but given that it's unlikely
anyone is using it yet, so it can probably be safely yanked and the
updated version included in a new release.
@tarcieri tarcieri merged commit e10f287 into master Dec 4, 2021
@tarcieri tarcieri deleted the elliptic-curve/revised-linear-combination-trait branch December 4, 2021 18:23
@tarcieri tarcieri mentioned this pull request Dec 4, 2021
tarcieri added a commit to RustCrypto/signatures that referenced this pull request Dec 4, 2021
tarcieri added a commit to RustCrypto/signatures that referenced this pull request Dec 4, 2021
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Dec 4, 2021
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Dec 4, 2021
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant