Skip to content

Conversation

@github-actions
Copy link
Contributor

Release
@floating-ui/vue@1.0.7

Diff for packages/vue

Diff
diff --git a/packages/vue/CHANGELOG.md b/packages/vue/CHANGELOG.md
index 9c923ae1..7bd9d286 100644
--- a/packages/vue/CHANGELOG.md
+++ b/packages/vue/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @floating-ui/vue
 
+## 1.0.7
+
+### Patch Changes
+
+- Update dependencies: `@floating-ui/utils@0.2.3`
+
 ## 1.0.6
 
 ### Patch Changes
diff --git a/packages/vue/package.json b/packages/vue/package.json
index 16a16d79..367610f2 100644
--- a/packages/vue/package.json
+++ b/packages/vue/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@floating-ui/vue",
-  "version": "1.0.6",
+  "version": "1.0.7",
   "description": "Floating UI for Vue",
   "publishConfig": {
     "access": "public"
@@ -26,7 +26,8 @@
     "dist"
   ],
   "scripts": {
-    "lint": "biome lint .",
+    "lint": "eslint .",
+    "format": "prettier --write .",
     "clean": "rimraf dist out-tsc",
     "test": "vitest run",
     "test:watch": "vitest watch",
@@ -56,7 +57,7 @@
     "vue"
   ],
   "dependencies": {
-    "@floating-ui/dom": "workspace:^",
+    "@floating-ui/dom": "^1.0.0",
     "@floating-ui/utils": "workspace:^",
     "vue-demi": ">=0.13.0"
   },
diff --git a/packages/vue/src/utils/unwrapElement.ts b/packages/vue/src/utils/unwrapElement.ts
index 236cfadc..3601f4bd 100644
--- a/packages/vue/src/utils/unwrapElement.ts
+++ b/packages/vue/src/utils/unwrapElement.ts
@@ -3,15 +3,22 @@ import type {ComponentPublicInstance} from 'vue-demi';
 
 import type {MaybeElement} from '../types';
 
-function isComponentPublicInstance(target: unknown): target is ComponentPublicInstance {
+function isComponentPublicInstance(
+  target: unknown,
+): target is ComponentPublicInstance {
   return target != null && typeof target === 'object' && '$el' in target;
 }
 
 export function unwrapElement<T>(target: MaybeElement<T>) {
   if (isComponentPublicInstance(target)) {
-    const element = target.$el as Exclude<MaybeElement<T>, ComponentPublicInstance>;
+    const element = target.$el as Exclude<
+      MaybeElement<T>,
+      ComponentPublicInstance
+    >;
 
-    return isNode(element) && getNodeName(element) === '#comment' ? null : element;
+    return isNode(element) && getNodeName(element) === '#comment'
+      ? null
+      : element;
   }
 
   return target as Exclude<MaybeElement<T>, ComponentPublicInstance>;
diff --git a/packages/vue/test/setupTests.ts b/packages/vue/test/setupTests.ts
index 304442ca..8ae484a7 100644
--- a/packages/vue/test/setupTests.ts
+++ b/packages/vue/test/setupTests.ts
@@ -11,43 +11,3 @@ vi.spyOn(window, 'requestAnimationFrame').mockImplementation(
     return 0;
   },
 );
-
-function isNullOrUndefined(a: any) {
-  return a == null;
-}
-
-// From https://github.com/jsdom/jsdom/issues/1261#issuecomment-512217225
-Object.defineProperty(HTMLElement.prototype, 'offsetParent', {
-  get() {
-    let element = this;
-    while (
-      !isNullOrUndefined(element) &&
-      (isNullOrUndefined(element.style) ||
-        isNullOrUndefined(element.style.display) ||
-        element.style.display.toLowerCase() !== 'none')
-    ) {
-      element = element.parentNode;
-    }
-
-    if (!isNullOrUndefined(element)) {
-      return null;
-    }
-
-    if (
-      !isNullOrUndefined(this.style) &&
-      !isNullOrUndefined(this.style.position) &&
-      this.style.position.toLowerCase() === 'fixed'
-    ) {
-      return null;
-    }
-
-    if (
-      this.tagName.toLowerCase() === 'html' ||
-      this.tagName.toLowerCase() === 'body'
-    ) {
-      return null;
-    }
-
-    return this.parentNode;
-  },
-});

Full diff
1.0.6...1.0.7.

@DanielleHuisman DanielleHuisman marked this pull request as ready for review June 26, 2024 06:47
@DanielleHuisman DanielleHuisman enabled auto-merge (squash) June 26, 2024 06:47
@DanielleHuisman DanielleHuisman merged commit 6ac0352 into main Jun 26, 2024
@DanielleHuisman DanielleHuisman deleted the upstream/vue-1.0.7 branch June 26, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants