RustPython changes for #824#829
Merged
windelbouwman merged 3 commits intoApr 14, 2019
Merged
Conversation
733a8c6 to
307689a
Compare
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
=========================================
- Coverage 63.28% 63.2% -0.09%
=========================================
Files 84 85 +1
Lines 13929 13955 +26
Branches 3088 3089 +1
=========================================
+ Hits 8815 8820 +5
- Misses 3108 3127 +19
- Partials 2006 2008 +2
Continue to review full report at Codecov.
|
cthulahoops
approved these changes
Apr 14, 2019
cthulahoops
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, aside from test failure on windows.
Contributor
|
Looks good to me too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #824 as requested. These are the changes to RustPython itself to support importing and running unittest.
The changes are: