Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upA bug in crossbeam v0.4.0 #75
Conversation
This comment has been minimized.
This comment has been minimized.
Shnatsel
commented
Dec 9, 2018
|
According to the version specification here 0.3.2 is vulnerable, and that's the most popular version right now according to crates.io download statistics: https://crates.io/crates/crossbeam Is 0.3.2 really affected? |
This comment has been minimized.
This comment has been minimized.
|
@Shnatsel I believe you're right. The bug only happened because we allowed the epoch GC to run destructors. Thanks for pointing this out! |
tarcieri
reviewed
Dec 9, 2018
| @@ -0,0 +1,56 @@ | |||
| [advisory] | |||
| # Identifier for the advisory (mandatory). Will be assigned a "RUSTSEC-YYYY-NNNN" | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tarcieri
reviewed
Dec 9, 2018
This comment has been minimized.
This comment has been minimized.
|
Looks good, thanks! |
tarcieri
merged commit c0fdc45
into
RustSec:master
Dec 9, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
pushed a commit
that referenced
this pull request
Dec 9, 2018
added a commit
that referenced
this pull request
Dec 9, 2018
This comment has been minimized.
This comment has been minimized.
|
Assigned |
stjepang
deleted the
stjepang:crossbeam-0.4.0
branch
Dec 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
stjepang commentedDec 9, 2018
No description provided.