Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upGranularity finer than crates #21
Comments
This comment has been minimized.
This comment has been minimized.
|
Perhaps it could in the future, but so far no one has specifically reported being inundated with too many false positive security reports from Doing this analysis incorrectly runs the risk of false negatives: failing to report legitimate vulnerabilities because the analysis was incorrect (or the vulnerability metadata was incorrect). Personally I think a KISS approach makes sense for now until spurious vulnerability reports become a real problem (we only have 8 vulns in the DB as it were). Happy to leave this issue open for further discussion though. |
This comment has been minimized.
This comment has been minimized.
|
Another idea is ability to include a checker in minor advisories. The checker would scan the code and report the issue conditionally. |
This comment has been minimized.
This comment has been minimized.
|
Another level of granularity to consider is individual cargo features. That said, I'm not sure how much sense this makes to micro-optimize. The best course of action is to upgrade. Ideally crate authors make that easy. |
vi commentedJul 20, 2018
•
edited
Shall cargo-audit, like cargo-geiger, track which functions are used and which are unused by the target crate and filter out vulnerabilities in unreferenced functions?
Otherwise there will be a stream of vulns in seldom used functions in deep dependencies, which would train users to shovel them away without much consideration, as most of then are not to the point. Or, if there would be little advisory traffic, will "penalize" crates or authors by figurating in a report even though the vulnerability is just in a tiny experimental doc-hidden non-default-feature-cfg function which almost nobody knows about (or be a reason against filing such advisories as insignificant).