Skip to content

Allow for a verb/activity or its ID when querying for statements #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reedmclean merged 1 commit into from
Dec 17, 2018
Merged

Allow for a verb/activity or its ID when querying for statements #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/RemoteLRS.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,12 @@ private function _queryStatementsRequestParams($query) {
) as $k
) {
if (isset($query[$k])) {
$result[$k] = $query[$k]->getId();
if (is_string($query[$k])) {
$result[$k] = $query[$k];
}
else {
$result[$k] = $query[$k]->getId();
}
}
}
foreach (
Expand Down
18 changes: 18 additions & 0 deletions tests/RemoteLRSTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,24 @@ public function testQueryStatements() {
$this->assertInstanceOf('TinCan\StatementsResult', $response->content);
}

public function testQueryStatementsWithActivityId() {
$lrs = new RemoteLRS(self::$endpoint, self::$version, self::$username, self::$password);
$response = $lrs->queryStatements(['activity' => COMMON_ACTIVITY_ID]);

$this->assertInstanceOf('TinCan\LRSResponse', $response);
$this->assertTrue($response->success, 'success');
$this->assertInstanceOf('TinCan\StatementsResult', $response->content);
}

public function testQueryStatementsWithVerbId() {
$lrs = new RemoteLRS(self::$endpoint, self::$version, self::$username, self::$password);
$response = $lrs->queryStatements(['verb' => COMMON_VERB_ID]);

$this->assertInstanceOf('TinCan\LRSResponse', $response);
$this->assertTrue($response->success, 'success');
$this->assertInstanceOf('TinCan\StatementsResult', $response->content);
}

public function testQueryStatementsWithAttachments() {
$lrs = new RemoteLRS(self::$endpoint, self::$version, self::$username, self::$password);
$response = $lrs->queryStatements(['limit' => 4, 'attachments' => true]);
Expand Down