Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Git Updater not working #1121

Closed
ismell opened this Issue · 5 comments

3 participants

@ismell

Using 4b58b40

I set the updater git command to C:\Program Files (x86)\Git\cmd\git.exe

But when it tries to execute I get the following

12-08 08:32:26 INFO �[0m[potato.core._base.updater] Checking for new version on github for CouchPotatoServer�[0m
12-08 08:32:26 ERROR �[31mException on /api/4d7dc8b45c254947876e90539bd6dee3/updater.check/ [GET]�[0m
Traceback (most recent call last):
  File "C:\Data\CouchPotato\CouchPotatoServer\libs\flask\app.py", line 1687, in wsgi_app
    response = self.full_dispatch_request()
  File "C:\Data\CouchPotato\CouchPotatoServer\libs\flask\app.py", line 1360, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "C:\Data\CouchPotato\CouchPotatoServer\libs\flask\app.py", line 1358, in full_dispatch_request
    rv = self.dispatch_request()
  File "C:\Data\CouchPotato\CouchPotatoServer\libs\flask\app.py", line 1344, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "C:\Data\CouchPotato\CouchPotatoServer\couchpotato\core\_base\updater\main.py", line 94, in checkView
    'update_available': self.check(),
  File "C:\Data\CouchPotato\CouchPotatoServer\couchpotato\core\_base\updater\main.py", line 78, in check
    if self.updater.check():
  File "C:\Data\CouchPotato\CouchPotatoServer\couchpotato\core\_base\updater\main.py", line 222, in check
    self.repo.fetch()
  File "C:\Data\CouchPotato\CouchPotatoServer\libs\git\repository.py", line 383, in fetch
    self._executeGitCommandAssertSuccess(command)
  File "C:\Data\CouchPotato\CouchPotatoServer\libs\git\repository.py", line 85, in _executeGitCommandAssertSuccess
    raise GitCommandFailedException(kwargs.get('cwd', self._getWorkingDirectory()), command, returned)
GitCommandFailedException: GitCommandFailedException: Command 'fetch' failed in C:\Data\CouchPotato\CouchPotatoServer (1):
'C:\Program' is not recognized as an internal or external command,

operable program or batch file.

Thanks,
Raul

@Begall

Git updater works fine, but you didn't quote C:\Program Files (x86)\Git\cmd\git.exe

Needs to be 'C:\Program Files (x86)\Git\cmd\git.exe', else all it sees is C:\Program. You could have worked this out from reading the log btw.

@ismell

I tried quoting it too

[updater]
notification = True
enabled = 1
git_command = 'C:\\Program Files (x86)\\Git\\cmd\\git.exe'
automatic = True
12-08 08:50:57 INFO �[0m[potato.core._base.updater] Checking for new version on github for CouchPotatoServer�[0m
12-08 08:50:57 ERROR �[31mException on /api/4d7dc8b45c254947876e90539bd6dee3/updater.check/ [GET]�[0m
Traceback (most recent call last):
  File "C:\Data\CouchPotato\CouchPotatoServer\libs\flask\app.py", line 1687, in wsgi_app
    response = self.full_dispatch_request()
  File "C:\Data\CouchPotato\CouchPotatoServer\libs\flask\app.py", line 1360, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "C:\Data\CouchPotato\CouchPotatoServer\libs\flask\app.py", line 1358, in full_dispatch_request
    rv = self.dispatch_request()
  File "C:\Data\CouchPotato\CouchPotatoServer\libs\flask\app.py", line 1344, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "C:\Data\CouchPotato\CouchPotatoServer\couchpotato\core\_base\updater\main.py", line 94, in checkView
    'update_available': self.check(),
  File "C:\Data\CouchPotato\CouchPotatoServer\couchpotato\core\_base\updater\main.py", line 78, in check
    if self.updater.check():
  File "C:\Data\CouchPotato\CouchPotatoServer\couchpotato\core\_base\updater\main.py", line 222, in check
    self.repo.fetch()
  File "C:\Data\CouchPotato\CouchPotatoServer\libs\git\repository.py", line 383, in fetch
    self._executeGitCommandAssertSuccess(command)
  File "C:\Data\CouchPotato\CouchPotatoServer\libs\git\repository.py", line 85, in _executeGitCommandAssertSuccess
    raise GitCommandFailedException(kwargs.get('cwd', self._getWorkingDirectory()), command, returned)
GitCommandFailedException: GitCommandFailedException: Command 'fetch' failed in C:\Data\CouchPotato\CouchPotatoServer (1):
The filename, directory name, or volume label syntax is incorrect.


@RuudBurger
Owner

You should escape the spaces, C:\\Program\ Files\ (x86)\\Git\\cmd\\git.exe

@RuudBurger RuudBurger closed this
@ismell

Actually I figured it out. According to http://docs.python.org/2/library/subprocess.html#converting-an-argument-sequence-to-a-string-on-windows It needs to use double quotes. So I ended up with "C:\Program Files (x86)\Git\cmd\git.exe" in the GUI or

[updater]
notification = True
enabled = 1
git_command = "C:\\Program Files (x86)\\Git\\cmd\\git.exe"
automatic = True

in the config.

Thanks,
Raul

@RuudBurger
Owner

Ah yes, that was also a possibility ;) Glad it's working now for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.