Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flickering, grey frames and low FPS when encoding gifs #1

Open
RuyiLi opened this issue Oct 11, 2019 · 4 comments
Open

Flickering, grey frames and low FPS when encoding gifs #1

RuyiLi opened this issue Oct 11, 2019 · 4 comments
Labels

Comments

@RuyiLi
Copy link
Owner

@RuyiLi RuyiLi commented Oct 11, 2019

When attempting to split certain gifs, some flickering grey pixels will appear on most of the frames. Additionally, the delay option to set the delay in milliseconds between consecutive frames does not work.

Steps to reproduce:

  1. Upload this gif:
    yum
  2. Change the delay option to 10 milliseconds.
  3. Click the split button.

Expected behavior:

  1. The roduced gif looks exactly the same as the decoded gif.
  2. The delay between each frame is 10 milliseconds.

What actually happens:

  1. The produced gif is covered in grey pixels.
    image
  2. The delay between each frame is much longer than 10 milliseconds.

Notes:

  • The "grey" color is #36393F, the same as Discord's background. This value is set as the filler background for gifs that have sizes that cannot be split perfectly into square tiles, so perhaps it is more accurate to say that "most of the pixels in the gif's frames are not rendering".
@ThomasLuu00

This comment has been minimized.

Copy link
Contributor

@ThomasLuu00 ThomasLuu00 commented Oct 11, 2019

I would like to look into this issue

@RuyiLi

This comment has been minimized.

Copy link
Owner Author

@RuyiLi RuyiLi commented Oct 11, 2019

The issue with the flickering pixels in the preview has been resolved by #2 (Thanks, @ThomasLuu00!), but the frame delay issue still remains.

@ThomasLuu00

This comment has been minimized.

Copy link
Contributor

@ThomasLuu00 ThomasLuu00 commented Oct 11, 2019

So it seems like there is a browser specific frame-rate lower limit for gifs.
https://github.com/jnordberg/gif.js/issues/17
I downloaded the encoded gifs and the delay looks fine.

@RuyiLi

This comment has been minimized.

Copy link
Owner Author

@RuyiLi RuyiLi commented Oct 11, 2019

Oh, that's unfortunate. I guess an alternative could just be to use multiple canvases to act as placeholders for the actual gifs in the preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.