Skip to content

Swift4.0 #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ashfurrow merged 3 commits into from
Sep 18, 2017
Merged

Swift4.0 #106

ashfurrow merged 3 commits into from
Sep 18, 2017

Conversation

@fpillet
Copy link
Member

@fpillet fpillet commented Sep 15, 2017

A few code tweaks, along with project files for Swift 4 / RxSwift 4 compatibility

@fpillet
Updated project and accompagnying files for Swift 4
55f3558 
Also cleaned up shared schemes to leave just what's needed for Action
@fpillet
Code changes for Swift 4
0c71f19
@fpillet
Copy link
Member Author

fpillet commented Sep 15, 2017

Also somewhat relates to #105

ashfurrow
ashfurrow approved these changes Sep 16, 2017
View reviewed changes
Copy link
Member

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! CI is just failing because its on an outdated Xcode version? I'm happy with merging if we open an issue to upgrade our CI once Xcode 9 is available. Good work!

@fpillet
Copy link
Member Author

fpillet commented Sep 16, 2017

I looked into the Travis log. iOS tests are passing just fine, then Travis builds for macOS, watchOS and tvOS -- no problem there too. Then it tries building with SPM (swift build) which fails. I don't know enough about SPM to fix the SPM file, which may be just what's needed (you need to point to the 4.0.0-alpha.1 branch of RxSwift but I don't know how to do this)

@ashfurrow
Copy link
Member

ashfurrow commented Sep 16, 2017

Cool cool, I'll take a look 👍

@fpillet
Copy link
Member Author

fpillet commented Sep 16, 2017

@ashfurrow Actually found the description I needed hidden in the docs! Fix on its way

@ashfurrow ashfurrow merged commit 35130e4 into RxSwiftCommunity:master Sep 18, 2017
@ashfurrow
Copy link
Member

ashfurrow commented Sep 18, 2017

This is great work – thanks!

@fpillet fpillet deleted the swift4.0 branch September 18, 2017 13:53
@ashfurrow ashfurrow mentioned this pull request Sep 18, 2017
Closed
@bobgodwinx bobgodwinx mentioned this pull request Oct 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashfurrow ashfurrow ashfurrow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fpillet @ashfurrow