-
Notifications
You must be signed in to change notification settings - Fork 150
RxSwift 4.0.0 target #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RxSwift 4.0.0 target #113
Conversation
Updated cartfile to target the new `RxSwift 4.0.0`
|
@fpillet @ashfurrow do think we should bump it version 3.4.0 ? |
|
@bobgodwinx I think 4.0.0. It's a major, not a minor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. If we're cutting a new build we might just want to make sure Travis runs the test on Swift 3.2 and Swift 4.0 snapshots
@bobgodwinx Actually are we sure we want ~> 4.0.0 dependency and now ~> 4.0 ? Otherwise we'll have to change this again when RxSwift 4.1 comes out
|
@bobgodwinx @fpillet Another point in question here. Many (most) apps didn't migrate to Swift 4 yet. Are we sure we don't want to keep Swift 4 on a branch for now? This 4.0.0 limit mean users who have the latest 3.x can't install Action. |
|
@freak4pc What I do is point to the version to use in the Readme, according to your requirements. RxSwiftExt now has 3 different options, depending on whether you need Swift 4, Swift 3 or Swift 2.x. |
|
@fpillet Gotya. Cool that's fair :) |
|
@freak4pc This is why we have versioning. Cocoapod should be able to do that based on git tags. for old version. If you specify |
|
Cool – let me know if/when we should ship a new version to CocoaPods. In the meantime, a PR adding a note about Swift 4 support to the Readme would be 💯 |
|
@ashfurrow sounds like a plan hopefully I could get that done for tomorrow. If you can you just drop a comment on #115 just to know what suites bests. |
RxSwift 4.0.0