Skip to content

Conversation

@bobgodwinx
Copy link
Member

  • Updated cartfile to target the new RxSwift 4.0.0

Updated cartfile to target the new `RxSwift 4.0.0`
@bobgodwinx bobgodwinx requested a review from fpillet October 18, 2017 09:16
@bobgodwinx
Copy link
Member Author

@fpillet @ashfurrow do think we should bump it version 3.4.0 ?

@freak4pc
Copy link
Member

freak4pc commented Oct 18, 2017

@bobgodwinx I think 4.0.0. It's a major, not a minor.

Copy link
Member

@freak4pc freak4pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If we're cutting a new build we might just want to make sure Travis runs the test on Swift 3.2 and Swift 4.0 snapshots

@bobgodwinx Actually are we sure we want ~> 4.0.0 dependency and now ~> 4.0 ? Otherwise we'll have to change this again when RxSwift 4.1 comes out

@freak4pc
Copy link
Member

@bobgodwinx @fpillet Another point in question here. Many (most) apps didn't migrate to Swift 4 yet. Are we sure we don't want to keep Swift 4 on a branch for now? This 4.0.0 limit mean users who have the latest 3.x can't install Action.

@fpillet
Copy link
Member

fpillet commented Oct 18, 2017

@freak4pc What I do is point to the version to use in the Readme, according to your requirements. RxSwiftExt now has 3 different options, depending on whether you need Swift 4, Swift 3 or Swift 2.x.

@freak4pc
Copy link
Member

freak4pc commented Oct 18, 2017

@fpillet Gotya. Cool that's fair :)

@bobgodwinx
Copy link
Member Author

@freak4pc This is why we have versioning. Cocoapod should be able to do that based on git tags. for old version. If you specify 3.3.1 but what I was saying is that the current master branch is still pointing to s.version = "3.3.0-alpha.1"

@bobgodwinx bobgodwinx merged commit 533f9c3 into RxSwiftCommunity:master Oct 18, 2017
@bobgodwinx
Copy link
Member Author

@freak4pc @fpillet am merging this since it passes all tests and opened up an issues on better versioning #115 main while users can point to master with RxSwift 4.0.0

@ashfurrow
Copy link
Member

Cool – let me know if/when we should ship a new version to CocoaPods. In the meantime, a PR adding a note about Swift 4 support to the Readme would be 💯

@bobgodwinx
Copy link
Member Author

@ashfurrow sounds like a plan hopefully I could get that done for tomorrow. If you can you just drop a comment on #115 just to know what suites bests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants