Skip to content

Ryan LaBarre Rylab

Rylab commented on pull request craiig/HOTDOGSEAGULL#13
Ryan LaBarre

That would be awesome! Just a heads up, I'm going out of town without internet access for ~10 days starting tomorrow, but I'll pick this up again w…

Rylab commented on pull request craiig/HOTDOGSEAGULL#13
Ryan LaBarre

All good feedback. 1-4 are easy improvements, as far as moving it to a module, I'm just getting into Node.JS with this project and unsure if I'll b…

Ryan LaBarre
  • Ryan LaBarre 75d3f11
    Just added the debugmessage textarea to index to stop a stupid JS war…
Rylab commented on pull request craiig/HOTDOGSEAGULL#13
Ryan LaBarre

Alright, totally rewrote it to generate the thumb via the /thumbgen endpoint rather than in the main directoryList loop. Now it returns the new thu…

Ryan LaBarre
  • Ryan LaBarre 600cd5f
    HUGE improvements to thumbnail generation, now returns URL on callbac…
Rylab commented on pull request craiig/HOTDOGSEAGULL#13
Ryan LaBarre

Just merged your recent commits into this pull since there was a minor merge conflict to work out in my footer-moved js :)

Ryan LaBarre
Rylab commented on pull request craiig/HOTDOGSEAGULL#13
Ryan LaBarre

Aha, figured it out finally! (fs.existsSync(thumb_dir + thumb_name)) returns true as soon as the file starts getting written by the fluent thread, …

Rylab commented on pull request craiig/HOTDOGSEAGULL#13
Ryan LaBarre

Ok, checkout my latest commits here. I have seen very occasionally, a thumbnail_src gets returned to the page, but the browser fails to render the …

Ryan LaBarre
  • Ryan LaBarre a327585
    Completely async and non-blocking thumbnail generation and inline loa…
  • Ryan LaBarre 3dee9d1
    Completely async and non-blocking thumbnail generation and inline loa…
  • 2 more commits »
Rylab closed pull request craiig/HOTDOGSEAGULL#14
Ryan LaBarre
Add large thumbnail to playfile screen; inline cast/play functions on indexes; updated styles
Rylab commented on pull request craiig/HOTDOGSEAGULL#14
Ryan LaBarre

Closing this since having two was confusing. Both sets of changes are in my "thumbnails" branch now, instead of separate branches, and ready for fi…

Rylab commented on issue craiig/HOTDOGSEAGULL#2
Ryan LaBarre

Scratch that, you have to use your LAN IP, e.g. http://192.168.0.77:3000 -- it has to be an IP that the Chromecast can communicate with. On Mar 17,…

Rylab commented on issue craiig/HOTDOGSEAGULL#2
Ryan LaBarre

You have to use http://127.0.01:3000 not localhost -- I believe that's mentioned in the readme. On Mar 17, 2014, at 5:01 PM, Matt notifications@git…

Rylab commented on pull request craiig/HOTDOGSEAGULL#13
Ryan LaBarre

The browser just will check for the generated thumbnails and display them without needing to refresh this way. It's still a normal node server proc…

Rylab commented on pull request craiig/HOTDOGSEAGULL#13
Ryan LaBarre

I have fluent-ffmpeg 1.6.0, it was installed by default when I did a normal npm install. You're right, thumbnails weren't being generated by the ro…

Rylab opened pull request craiig/HOTDOGSEAGULL#14
Ryan LaBarre
Add large thumbnail to playfile screen; inline cast/play functions on indexes; updated styles
16 commits with 273 additions and 83 deletions
Ryan LaBarre
  • Ryan LaBarre a61c993
    Added full-size thumb to playfile detail screen, made Back Up nav con…
Ryan LaBarre
  • Ryan LaBarre 91dfd6d
    mini security audit, dont even attempt to generate thumbnails for fil…
Ryan LaBarre
  • Ryan LaBarre 3555737
    stop unnecessariy logging every thumbnail creation json options objec…
Ryan LaBarre

Added some nifty logic to wait up to a few seconds for initial thumbnail generation -- this solves the initial issue of first-load not showing thum…

Ryan LaBarre
  • Ryan LaBarre c310dbd
    wait for up to 4 seconds max for initial thumbnail generation upon lo…
Rylab commented on pull request craiig/HOTDOGSEAGULL#13
Ryan LaBarre

Pretty sure this is all ready to merge back into master, been testing the crap out of it and it's solid.

Rylab commented on pull request craiig/HOTDOGSEAGULL#13
Ryan LaBarre

Note, you may (likely) need to do an npm install again to get this new req, but it's worth it, I promise!

Ryan LaBarre
  • Ryan LaBarre 821d99f
    require mkdirp to fix crashes related to jumping quickly into sub-sub…
Rylab commented on pull request craiig/HOTDOGSEAGULL#13
Ryan LaBarre

Ok, I'm probably going to come off as a bit OCD, but fixed a crash related to jumping straight into a sub-subdirectory before any thumbnails were c…

Rylab commented on pull request craiig/HOTDOGSEAGULL#13
Ryan LaBarre

Added native display of common Chrome-compatible image types (jpg, png, webp, etc) -- set a static width but left height auto to keep original aspe…

Something went wrong with that request. Please try again.