Fix DMA copy fast path line size when xCount < stride #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdkchan
force-pushed
the
fix-fast-dma-copy
branch
from
7ce1f76
to
4f16b7b
Compare
|
Download the artifacts for this pull request: |
marysaka
approved these changes
Dec 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy could be out of bounds before if
xCountwas less than stride, as the span size is calculated based on the stride andxCount(so it could be missing a few bytes at the end). This change makes it not copy any more thanxCount. I'm not sure if the fast path should be used in this case though, as technically the data of the few missing pixels would be just 0.This fixes some random crashes in the Youtube app and maybe some other games that does DMA copy with linear source textures.
Testing to ensure that it did not regress any game is welcome.