Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement/Stub mnpp:app service and some hid calls #3131

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Conversation

AcK77
Copy link
Member

@AcK77 AcK77 commented Feb 17, 2022

This PR implement/stub the mnpp:app service (closes #3107) accordingly to RE, which seems to do some telemetry for China region only, so everything is stubbed.

This PR fixes some inconsistencies in the hid service too and stub EnableSixAxisSensorUnalteredPassthrough, IsSixAxisSensorUnalteredPassthroughEnabled, LoadSixAxisSensorCalibrationParameter, GetSixAxisSensorIcInformation calls (closes #3123 and closes #3124).

This PR Implement/Stub the `mnpp:app` service (closes Ryujinx#3107) accordingly to RE, which seems to do some telemetry for China region only, so everything is stubbed.

This PR fixes some inconsistencies in the hid service too and stub EnableSixAxisSensorUnalteredPassthrough, IsSixAxisSensorUnalteredPassthroughEnabled, LoadSixAxisSensorCalibrationParameter, GetSixAxisSensorIcInformation calls (closes Ryujinx#3123 and closes Ryujinx#3124).
@AcK77 AcK77 added stub Contains a stubbed service call service-implementation Related to a service implementation service:bcat Related to the bcat module (Ryujinx.HLE.HOS.Services.Bcat) service:hid Related to the hid module (Ryujinx.HLE.HOS.Services.Hid) labels Feb 17, 2022
Copy link
Member

@gdkchan gdkchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@marysaka marysaka merged commit a113ed0 into Ryujinx:master Feb 18, 2022
@AcK77 AcK77 deleted the mnpp branch February 20, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service:bcat Related to the bcat module (Ryujinx.HLE.HOS.Services.Bcat) service:hid Related to the hid module (Ryujinx.HLE.HOS.Services.Hid) service-implementation Related to a service implementation stub Contains a stubbed service call
Projects
None yet
3 participants