Fix shader textureSize with multisample and buffer textures #3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
GUI-less (SDL2) |
|
Fixes games that had issues with it! Rune Factory 5 has all of its graphical issues fixed (Special skills, enemy attacks, Tag attack skills, water effects, spawn orb etc) Bubble Bobble 4 Friends is emulated correctly too now on OpenGL, with SPIR V its still crashing when the effect is supposed to be shown but that's unrelated to this.
Good job as always @gdkchan ! |
|
Also here's a video to show the game with the issue and now fixed. Master: Master.mp4PR: Pr.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multisample and buffer overloads does not take a lod parameter, because multisample and buffer textures can't have mipmaps. This removes the inexistent parameter from the GLSL code generation.
Fixes #3238.