Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove save data creation prompt #3252

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Conversation

MutantAura
Copy link
Collaborator

This prompt was fairly redundant and was just another box to click.
Creation of mod directories do not require this extra step and it seems weird to keep this one. If there is a particular reason to keep this around then I'm all ears but I currently can't see a scenario where a user wishes to open a directory... then says "No" when asked to create one.

The logger now simply reads when a directory has been created instead.

@MutantAura MutantAura added the gui Related to Ryujinx.Ui label Apr 3, 2022
@gdkchan gdkchan added the enhancement New feature or request label Apr 3, 2022
Ryujinx/Ui/Widgets/GameTableContextMenu.cs Outdated Show resolved Hide resolved
Ryujinx/Ui/Widgets/GameTableContextMenu.cs Outdated Show resolved Hide resolved
Copy link
Member

@gdkchan gdkchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@Thealexbarney
Copy link
Contributor

The reason for the prompt is because creating a save involves more than simply creating a directory. And because there's no easy option to delete a save once created. You can use a homebrew save manager like JKSV to do it, but most users won't know that

@MutantAura
Copy link
Collaborator Author

Do you think there's necessarily an issue with that though? While there is more going on in the backend to log what game is which etc. All that is really happening to the user is a directory creation. It isn't adding multiple MB's worth of data to their install and if they had the game available to create a directory then chances are they will eventually play it and auto create one anyway.

@AcK77 AcK77 merged commit 6a9e9b5 into Ryujinx:master Apr 8, 2022
@MutantAura MutantAura deleted the begone-prompt branch April 10, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gui Related to Ryujinx.Ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants