Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force scissor on clear if scissor is disabled #3258

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

gdkchan
Copy link
Member

@gdkchan gdkchan commented Apr 4, 2022

We should not force a scissor on clears if the respective scissor is disabled.
This fixes some glitckes on Kirby and the Forgotten Land and maybe other titles caused by textures not being fully cleared, and "garbage" data from previous textures being carried over.
Before:
image
After:
image

@gdkchan gdkchan added gpu Related to Ryujinx.Graphics fix Fix something labels Apr 4, 2022
@Leischii
Copy link

Leischii commented Apr 4, 2022

Fixes every way this bug was visible ingame (text overlapping, symbols being cut off, menu flickering)

image

image

image

Copy link
Member

@riperiperi riperiperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

@gdkchan gdkchan merged commit b2a2255 into Ryujinx:master Apr 4, 2022
@gdkchan gdkchan deleted the clear-scissor-disable branch April 4, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix something gpu Related to Ryujinx.Graphics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants