Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avalonia - Couple fixes and improvements #3451

Merged
merged 11 commits into from
Jul 11, 2022
Merged

Conversation

emmauss
Copy link
Contributor

@emmauss emmauss commented Jul 8, 2022

Includes;

1.Fix crash with the updater on launch.
2.Reduce size of cheat window
3.Enable Tiered Compilation
4.Remove warnings from the avalonia project

@gdkchan gdkchan added gui Related to Ryujinx.Ui fix Fix something labels Jul 8, 2022
Copy link
Member

@gdkchan gdkchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe its worth addressing the remaining issues here too to avoid opening many small PRs. I'm talking about the compiler warnings, and re-enabling tiered compilation for Avalonia.

Ryujinx.Ava/Ui/Windows/MainWindow.axaml.cs Show resolved Hide resolved
@emmauss emmauss changed the title Avalonia - Fix Updater check crash Avalonia - Couple of fixes and improvements Jul 9, 2022
@emmauss emmauss changed the title Avalonia - Couple of fixes and improvements Avalonia - Couple fixes and improvements Jul 9, 2022
Ryujinx.Ava/Common/ApplicationHelper.cs Outdated Show resolved Hide resolved
Ryujinx.Ava/Ryujinx.Ava.csproj Outdated Show resolved Hide resolved
Ryujinx.Ava/Ryujinx.Ava.csproj Outdated Show resolved Hide resolved
Ryujinx.Ava/Ui/Windows/CheatWindow.axaml Outdated Show resolved Hide resolved
Ryujinx.Headless.SDL2/Ryujinx.Headless.SDL2.csproj Outdated Show resolved Hide resolved
</PropertyGroup>

<ItemGroup>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double empty line and indentation is off (maybe another case of it using Tabs rather than spaces).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not fixed.

Copy link
Contributor Author

@emmauss emmauss Jul 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be fixed now.

@gdkchan
Copy link
Member

gdkchan commented Jul 9, 2022

From what I'm seeing from docs, ReadyToRun significantly increases the binary size. Have you compared them and have some numbers to show for the executable size? And does it provide a significant improvement to justify the size increase?

@emmauss
Copy link
Contributor Author

emmauss commented Jul 9, 2022

For ava, the folder is 171MB, and the executable 153MB

@emmauss
Copy link
Contributor Author

emmauss commented Jul 9, 2022

Addressed review

@gdkchan
Copy link
Member

gdkchan commented Jul 9, 2022

The csproj files were changed from spaces to tab, while it should be the opposite.

@emmauss
Copy link
Contributor Author

emmauss commented Jul 9, 2022

The csproj files were changed from spaces to tab, while it should be the opposite.

It's corrected

@gdkchan
Copy link
Member

gdkchan commented Jul 9, 2022

The csproj files were changed from spaces to tab, while it should be the opposite.

It's corrected

The axaml files seems to have the same issue.

@emmauss
Copy link
Contributor Author

emmauss commented Jul 9, 2022

The csproj files were changed from spaces to tab, while it should be the opposite.

It's corrected

The axaml files seems to have the same issue.

That's also fixed

@marysaka marysaka requested a review from gdkchan July 10, 2022 13:24
Copy link
Member

@gdkchan gdkchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@gdkchan
Copy link
Member

gdkchan commented Jul 10, 2022

One thing to note is that this is also enabling tiered compilation on the other projects (headless and GTK UI).. So it could also have a small improvement on startup time, but I doubt it would be as noticeable as Avalonia.

@AcK77 AcK77 merged commit 7d9a5fe into Ryujinx:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix something gui Related to Ryujinx.Ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants