Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avalonia - Make tooltips more useful and descriptive, update Spanish localization #3453

Merged
merged 8 commits into from
Jul 11, 2022
Merged

Avalonia - Make tooltips more useful and descriptive, update Spanish localization #3453

merged 8 commits into from
Jul 11, 2022

Conversation

MetrosexualGarbodor
Copy link
Collaborator

Using an emulator for the first time can be confusing, and many people assume certain settings do things they actually don't, which is not helped by the settings' descriptions. Hell, I used Ryujinx for over a year before I understood what "FS integrity checks" did.
My goal here is to keep it as short as possible, while still giving relevant information that the average user can grasp. Below are my proposed changes:

docked

vsync

fs

expanDRAM

ims

pptc

MMM

shader cache

backend threading

audio

lan mode

discord_rich_presence

I'm a bit iffy on the shader cache and memory manager modes' tooltips, so if anyone has some suggestions for those, I'm all ears. I'm also aware that people will still not read the Vsync tooltip and turn it off, unless the option is renamed to "Frame Limiter" or something similar.
The all-caps suggestions ("OFF if unsure") will be replaced by bold lowercase when it's possible and I figure out how to do it.

Apologies to all of you who did a localization for making you do it again lol.

@gdkchan gdkchan added enhancement New feature or request gui Related to Ryujinx.Ui labels Jul 9, 2022
@gdkchan
Copy link
Member

gdkchan commented Jul 9, 2022

I think the part that says "in handheld mode, handheld controls will be used" is not entirely correct, as most games works fine in handheld mode with player 1 configured only.

And for the VSync tooltip, it shouldn't mention that it can be toggled with Tab key as those shortcuts are configurable now. And Tab to toggle VSync is not even working on Avalonia right now.

@german77

This comment was marked as off-topic.

@Moonlacer
Copy link

More descriptive, I like it. Somehow, I think adding more text (but not too much) to a tooltip makes it seem higher quality. I am very much looking forward to seeing Avalonia being released to the regular builds... 👍

Copy link
Contributor

@Niwu34 Niwu34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work: Loving the changes
Gave it a quick read and noticed some tiny things

A few more things that seem a bit odd are the tooltips for the logs:
I'd either remove them or give them a more detailed description

Ryujinx.Ava/Assets/Locales/en_US.json Outdated Show resolved Hide resolved
Ryujinx.Ava/Assets/Locales/en_US.json Outdated Show resolved Hide resolved
Ryujinx.Ava/Assets/Locales/en_US.json Outdated Show resolved Hide resolved
Ryujinx.Ava/Assets/Locales/en_US.json Outdated Show resolved Hide resolved
Ryujinx.Ava/Assets/Locales/en_US.json Outdated Show resolved Hide resolved
@gdkchan
Copy link
Member

gdkchan commented Jul 9, 2022

We will need some way to indicate that the other locale files should be updated too. Removing the modified entries from the other locale files and moving them to the bottom on the English one would work, but would probably be annoying to do without a script to automate it.

@MetrosexualGarbodor
Copy link
Collaborator Author

I was thinking of pinging past localization contributors if they don't respond within some days of merging this.

The lines which have had any significant changes are: 112, 113, 114, 126, 167, 421, 425, 428, 429, 430, 435, 436, 437, 438, 439, 443, 444, 445, 446, 447, 453, 454, 455, 456, 457, 458, 459, 460, 464, 465, 466, 481, 482, 497, 571

@Niwu34
Copy link
Contributor

Niwu34 commented Jul 9, 2022

I'm waiting for all the Avalonia related stuff to be merged before updating the German localization again.
Will open a PR after that (hoping for some feedback from my German fellows) 😄

Copy link
Contributor

@marysaka marysaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marysaka marysaka enabled auto-merge (squash) July 10, 2022 13:23
@marysaka marysaka merged commit f4c47f3 into Ryujinx:master Jul 11, 2022
@MetrosexualGarbodor MetrosexualGarbodor deleted the MetrosexualGarbodor-tooltip-cleanup-plus-spanish-locale-update branch July 12, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gui Related to Ryujinx.Ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants