Propagate Shader phi nodes with the same source value from all blocks #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marysaka
approved these changes
Jul 10, 2022
grayexoc
approved these changes
Jul 10, 2022
|
Almost perfect ! Thank you very much.
|
AcK77
approved these changes
Jul 11, 2022
|
not work stuck and crash on |
santibe
added a commit
to santibe/Ryujinx
that referenced
this pull request
Jul 18, 2022
…l blocks (Ryujinx#3457)" This reverts commit 4523a73.
zombie167 how do you install MH Rise v10.0.3 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to ensure that all variables only have a single assignment to keep optimizations simple, we keep the IR in SSA form. It is possible for a variable to be set to the same value in multiple blocks, and currently the shader translator will insert a copy on each one of them. Since it does not know that the values are actually the same, it will insert a Phi on blocks with multiple predecessors where the value is used. But the Phi is not actually needed in this case, if the value is actually the same on all of them, it doesn't matter from where it comes from.
This change extends the optimizer to also propagate the Phi source values if the value is always the same, regardless of the incoming block. This makes the generated shader code smaller and better.
The main noticeable benefit here is that bindless elimination now works on more cases, which fixes the flickering that Monster Hunter Rise had with latest update and Sunbreak expansion.
Note: The game still needs the other fixes (#3431 and #3425) to actually run, of course.