Avoid scaling 2d textures that could be used as “3d“

[riperiperi]

This PR adds another “safe mode” toggle for scaling that disables it for 2d textures that might be used as 3D. These textures essentially have a line of “slices” stacked in the x direction, rather than using a real 3d texture, as it is easier to render into. Games that dynamically update a 3D look-up-table to do tone mapping might do this. If that texture were scaled, the slices would blend into each other, causing black to appear as red, and bright red to darken too.

Some notes about the rules:

• It is assumed that the slices are stacked in the x-direction.
• It is assumed that the “slice” count is the same as the height, so the width is the height squared.
• Due to other rules, minimum affected texture size is 64x8

Hopefully this should fix issue #3456 , but all those games are on different engines so it does need tested.

[github-actions]

Download the artifacts for this pull request:

• ryujinx-Release-1.1.0+5908521-linux_x64
• ryujinx-Release-1.1.0+5908521-osx_x64
• ryujinx-Release-1.1.0+5908521-win_x64

Experimental GUI (Avalonia)

• ava-ryujinx-Release-1.1.0+5908521-linux_x64
• ava-ryujinx-Release-1.1.0+5908521-osx_x64
• ava-ryujinx-Release-1.1.0+5908521-win_x64

GUI-less (SDL2)

• sdl2-ryujinx-headless-Release-1.1.0+5908521-linux_x64
• sdl2-ryujinx-headless-Release-1.1.0+5908521-osx_x64
• sdl2-ryujinx-headless-Release-1.1.0+5908521-win_x64

Only for Developers

• ava-ryujinx-Debug-1.1.0+5908521-linux_x64
• ava-ryujinx-Debug-1.1.0+5908521-osx_x64
• ava-ryujinx-Debug-1.1.0+5908521-win_x64
• ryujinx-Debug-1.1.0+5908521-linux_x64
• ryujinx-Debug-1.1.0+5908521-osx_x64
• ryujinx-Debug-1.1.0+5908521-win_x64
• sdl2-ryujinx-headless-Debug-1.1.0+5908521-linux_x64
• sdl2-ryujinx-headless-Debug-1.1.0+5908521-osx_x64
• sdl2-ryujinx-headless-Debug-1.1.0+5908521-win_x64

[meisiek]

Fixes the red screen in "Lost in Random", "Far: Changing Tides" and "A Hat in Time".
I don't own the other games.

[edisionnano]

Could it fix the similar issue occuring on AMD linux when playing SMO in handheld mode?

[riperiperi]

No, I believe that issue is caused by out of bounds image access, which needs a feature to be available and enabled on vulkan, and I guess on opengl there is no workaround.

EDIT: This extension does cover out of bounds texel fetch on opengl, might be worth looking into:
https://www.khronos.org/registry/OpenGL/extensions/KHR/KHR_robust_buffer_access_behavior.txt

[EliEron]

I can confirm the PR fixes the issue in World's End Club.

2x Master:

2x PR:

[Niwu34]

Fixes Cruis'n Blast & A Hat in Time & Lost in Random
Master:

PR3464:

Master:

PR3464:

Master:

PR3464:

[gdkchan]

Seems to be working on Demon's Gaze Extra too:

[gdkchan]

lgtm, thanks. Nice to see this issue finally fixed.

[zombie167]

Fix red tint
Sherlock Holmes: The Devil's Daughter

Master build

PR build

Pascal's Wager: Definitive Edition

Master build

PR build

[Djipi71]

Test the Build. I can confirm that the scaling problem red is now solved.
Agatha Christie The First Cases
Sherlock Sin and Punishment
Lost in random
Sherlock Devil Daughter

All are perfect now