Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure to load latest version of ffmpeg libraries first #3473

Merged
merged 1 commit into from
Jul 24, 2022
Merged

fix: Ensure to load latest version of ffmpeg libraries first #3473

merged 1 commit into from
Jul 24, 2022

Conversation

marysaka
Copy link
Contributor

@marysaka marysaka commented Jul 15, 2022

Fix a possible crash related to older version of ffmpeg being loaded
instead of the one shipped with the emulator.

Fix a possible crash related to older version of ffmpeg being loaded
instewad of the one shipped with the emulator.
@marysaka marysaka added gpu Related to Ryujinx.Graphics fix Fix something nvdec Suggestion or issue related to nvdec codec labels Jul 15, 2022
@marysaka marysaka requested review from AcK77 and gdkchan July 15, 2022 23:54
@gdkchan
Copy link
Member

gdkchan commented Jul 16, 2022

Are you sure that this fixes the issue? I think it would be better to enforce it to use the version shipped with the emulator, regardless of whats on the system (not sure why it's not doing that already, it should always search on the application folder first, I think?)

@marysaka
Copy link
Contributor Author

marysaka commented Jul 17, 2022

Are you sure that this fixes the issue? I think it would be better to enforce it to use the version shipped with the emulator, regardless of whats on the system (not sure why it's not doing that already, it should always search on the application folder first, I think?)

We only ship ffmpeg on Windows, as already detailed on the other PR, this is to support older Linux distro still supported like Ubuntu 20.04 LTS (EOL in 2025).

EDIT: Ubuntu 22.04 LTS released this year ship only 4.4 and EOL in 2027

@marysaka marysaka merged commit 3a3380f into Ryujinx:master Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix something gpu Related to Ryujinx.Graphics nvdec Suggestion or issue related to nvdec codec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants