Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few minor documentation fixes. #3599

Merged
merged 5 commits into from
Aug 19, 2022
Merged

A few minor documentation fixes. #3599

merged 5 commits into from
Aug 19, 2022

Conversation

CloneDeath
Copy link
Contributor

I fixed a few warnings, stemming from various documentation issues.

@AcK77 AcK77 added miscellaneous Related to some project not listed in labels fix Fix something labels Aug 17, 2022
@github-actions
Copy link

github-actions bot commented Aug 17, 2022 •
edited
Loading

Download the artifacts for this pull request:

Experimental GUI (Avalonia)
GUI-less (SDL2)
Only for Developers

@gdkchan
Copy link
Member

gdkchan commented Aug 18, 2022

There's this too if you want to take a look https://github.com/Ryujinx/Ryujinx/blob/master/Ryujinx.Graphics.Gpu/Shader/GpuAccessorBase.cs
It uses inheritdoc, but there's no base class.

@CloneDeath
Copy link
Contributor Author

CloneDeath commented Aug 18, 2022 •
edited
Loading

It uses inheritdoc, but there's no base class.

Good catch. Fixed.

gdkchan
gdkchan approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@gdkchan gdkchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@gdkchan gdkchan merged commit 7defc59 into Ryujinx:master Aug 19, 2022
@CloneDeath CloneDeath deleted the minor-documentation-fixes branch August 24, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marysaka marysaka marysaka approved these changes

@AcK77 AcK77 AcK77 approved these changes

@gdkchan gdkchan gdkchan approved these changes

@riperiperi riperiperi Awaiting requested review from riperiperi

Assignees
No one assigned
Labels
fix Fix something miscellaneous Related to some project not listed in labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CloneDeath @gdkchan @marysaka @AcK77