Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'Purge PPTC Cache' label & tooltip to reflect function behavior #3601

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Change 'Purge PPTC Cache' label & tooltip to reflect function behavior #3601

merged 2 commits into from
Aug 19, 2022

Conversation

EmulationFanatic
Copy link
Contributor

@EmulationFanatic EmulationFanatic commented Aug 18, 2022

This PR modifies the "Purge PPTC Cache" function label to instead be "Queue PPTC Rebuild", and modifies the associated tooltip to be "Trigger PPTC to rebuild at boot time on the next game launch."
The reason for this change is that executing this function only deletes the PPTC .cache file, leaving the .info file intact. This means all functions cached so far are still intact in a list in the .info file, and the .cache file will be rebuilt from said file on next boot of the game.
In lieu of changing the function to actually delete both the .cache and .info files, we should at least be descriptive about the function's true behavior.

Preview of GTK changes (also changed in Avalonia)
Before:
image

After:
image

@EmulationFanatic EmulationFanatic added gui Related to Ryujinx.Ui fix Fix something labels Aug 18, 2022
@EmulationFanatic EmulationFanatic requested review from emmauss, gdkchan, AcK77 and riperiperi and removed request for emmauss and gdkchan August 18, 2022 11:45
@Narugakuruga
Copy link
Contributor

Deleting .info files is useful in some cases.
For example updating Ryujinx from an very old version could cause PPTC related bugs.

@EmulationFanatic
Copy link
Contributor Author

Deleting .info files is useful in some cases. For example updating Ryujinx from an very old version could cause PPTC related bugs.

Yes, I agree.
This PR does not change any functions, it just updates the description of what the function actually does when clicked.

@AcK77 AcK77 merged commit 53cc9e0 into Ryujinx:master Aug 19, 2022
@EmulationFanatic EmulationFanatic deleted the PPTC_purge_honesty branch June 26, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix something gui Related to Ryujinx.Ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants