Do not output ViewportIndex on SPIR-V if GPU does not support it #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gdkchan Well it looks like you've done it. Ryujinx_1.1.0+03839f6_2022-08-30_00-32-55.log Obviously performance work needs to happen, but it's playable now. Can't wait to see this merged! |
riperiperi
approved these changes
Aug 30, 2022
marysaka
approved these changes
Sep 10, 2022
marysaka
force-pushed
the
spv-viewport-index
branch
from
43e8d47
to
1da9fea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change remove SPIR-V
ViewportIndexoutputs if the GPU does not support it, in an attempt to support older GPUs. Nothing should change for OpenGL as it does not currently outputgl_ViewportIndexin GLSL.Testing is welcome, it should not affect newer GPUs (for NVIDIA, it should not affect Maxwell 2nd gen and newer).