Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ava UI: Reorder settings of Resolution Scaler #4270

Merged
merged 1 commit into from Jan 12, 2023

Conversation

AcK77
Copy link
Member

@AcK77 AcK77 commented Jan 11, 2023

This PR re-order the settings of the Resolution Scaler in Ava UI to follow what we currently have in GTK.

Before:
image

After:
image

I've sorted the configurations fields by their categories in LoadCurrentConfiguration and SaveSettings too. Some cleanup have to be done in a near future as those names suggest.

(Closes some items of #3662)

@AcK77 AcK77 added gui Related to Ryujinx.Ui fix Fix something labels Jan 11, 2023
@AcK77 AcK77 changed the title ava: Reorder settings of Resolution Scaler Ava UI: Reorder settings of Resolution Scaler Jan 11, 2023
Copy link
Member

@gdkchan gdkchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, using Length - 1 instead of 4 is preferable. Then if we add more resolution scale presets (which will make the custom entry move down), we don't need to change that code.

@AcK77
Copy link
Member Author

AcK77 commented Jan 12, 2023

If possible, using Length - 1 instead of 4 is preferable. Then if we add more resolution scale presets (which will make the custom entry move down), we don't need to change that code.

Sadly it's not possible since we avoid to access of the view from the ViewModel, The value is a long and not an enum too, so I can't know the Length...

@AcK77 AcK77 merged commit 30862b5 into Ryujinx:master Jan 12, 2023
@AcK77 AcK77 deleted the ava-set-rescale branch January 12, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix something gui Related to Ryujinx.Ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants