Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing hotkeys, allow modifiers and controller button mappings on Avalonia #4503

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add missing hotkeys, allow modifiers and controller button mappings on Avalonia #4503

wants to merge 3 commits into from

Conversation

gdkchan
Copy link
Member

@gdkchan gdkchan commented Mar 3, 2023

This is adding a few features that have been requested related to hotkeys on Avalonia:

  • Allow the few missing options that does have hotkeys to be configured (toggle fullscreen, toggle docked mode and exit).
  • Allow key modifiers (control, alt, shift and command on macOS) to be part of hotkey mappings (rather than just a single key).
  • Allow single controller buttons and button combinations to be used as hotkey. Currently it is possible to have one keyboard hotkey and one controller hotkey for each configurable hotkey.

I do not plan to implement this on GTK.

TODO:

  • Config file migration?
  • Remove old hotkey management from Avalonia.
  • Update hotkeys on menus.
  • Investigate a few bugs.
  • Add new strings to locale files.

@gdkchan gdkchan added enhancement New feature or request gui Related to Ryujinx.Ui labels Mar 3, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Download the artifacts for this pull request:

Experimental GUI (Avalonia)
GUI-less (SDL2)
Only for Developers

@AcK77 AcK77 mentioned this pull request Apr 16, 2023
Open
@gdkchan gdkchan mentioned this pull request Jan 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request gui Related to Ryujinx.Ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gdkchan