Move MaxUboSize definition #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix a crash on Ryujinx.ShaderTools caused by the absence of an OpenGL context.
gdkchan
reviewed
Dec 9, 2018
| @@ -106,6 +108,8 @@ public GlslDecompiler() | |||
| { ShaderIrInst.Utof, GetUtofExpr }, | |||
| { ShaderIrInst.Xor, GetXorExpr } | |||
| }; | |||
|
|
|||
| GlslDecompiler.MaxUboSize = MaxUboSize / 16; | |||
There was a problem hiding this comment.
IMO, its weird that a static member is being set on the constructor. I think its better to either make it a instance member, or allow it to be set externally aswell.
There was a problem hiding this comment.
Imo, a readonly member would be the best approach to this, as unnecessarily introducing statics is a bad way to go about it. Because what if we somehow need to have 2 instances of GlslDecl with a different MaxUboSize (not sure how likely this will be but hypothetically speaking)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix a crash on Ryujinx.ShaderTools caused by the absence of an
OpenGL context.