Add inbuilt Opengl renderer to window #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as an aside, code for the widget is here, https://gist.github.com/emmauss/15fef952fe25d7f838ccd6a5f438249b |
AcK77
reviewed
Feb 6, 2020
Changelog: - Reapply some changes that got lost while rebasing from Ryujinx#904 - Make sure to guarantee exclusivity on the GL context (fixing multiple possible race conditions on Windows) - Avoid making GLRenderer disposed multiple time
|
addressed comments |
I guess this is a typo?
I think it should be removed. |
AcK77
requested changes
Feb 6, 2020
Xpl0itR
suggested changes
Feb 6, 2020
There was a problem hiding this comment.
- Instead of hiding the game list and games loaded info separately you should just remove the whole
MainBox(both the game list and footer are in this box widget). Its currently not exposed to the code, you'll have to add its binding. - nit: If you open MainWindow.glade in glade you will see that the footer box has spaces for 4 child widgets but only has 3 child widgets.
- The custom gl widget has some random console logging. https://gist.github.com/emmauss/15fef952fe25d7f838ccd6a5f438249b#file-glwidget-cs-L278
- Resizing and fullscreening the window is bugged if the window is not being rendered to
Done
Will remove it in an update to the wigdet package
Noting I can do about this. I've tried clearing the screen after resizing. it did not work. Addressed comments |
AcK77
approved these changes
Feb 11, 2020
gdkchan
reviewed
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now ditch the extra window. Allows rendering in the main window. the old GLScreen is still there, but can not be accessed anymore through. Will remove it if its decided its no longer necessary.
So far, I've not noticed any slowdowns. the rendering logic is more or less the same, and its multithreaded. Contrary to what I thought before, you can modify the underlying context in gtk, with it crashing on you.
This PR is ready for review.