Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always send 'Accept: */*' HTTP header to webmention endpoints #31

Open
Ryuno-Ki opened this issue Apr 30, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@Ryuno-Ki
Copy link
Owner

commented Apr 30, 2019

I'm not happy with the approach in snarfed@a67be86
Feels fishy. I'd rather extend the Accept header to something more concrete.

@snarfed Do you happen to have more experience here by now?

@Ryuno-Ki

This comment has been minimized.

Copy link
Owner Author

commented Apr 30, 2019

@snarfed

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

hi! hmm. not a lot more experience, no. but webmention responses don't have to be any specific content type - they're actually often empty - so i wouldn't recommend that we tighten this to any concrete types. if anything, we should probably just drop Accept: */* altogether, since i only added it to work around my own code in Bridgy.

@Ryuno-Ki

This comment has been minimized.

Copy link
Owner Author

commented May 11, 2019

Hi @snarfed,

hm, I thought about it (while reading the W3C standard to ensure compliance).
I'm not feeling comfortable with allowing everything (even blobs).

What about restricting it to text/*?
Maybe with application/json in addition?
I'd then just wait for issues to be filled.

@snarfed

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

hmm! for fetching source URLs, and maybe even GETs to webmention endpoints, i might agree. for webmention POSTs though, again, the most common response is empty, often without Content-Type at all, and the spec doesn't say they have to be any specific type, as mentioned above. so i'd worry about sending any specific Accept value, since it might make a server think it can't satisfy the requested type(s).

(at a higher level, content negotiation (Accept header etc) makes me sad in general. nice idea in theory, but i suspect it's turned out to be a net negative for web development at large. much more painful and error prone than useful in practice. more recent indieweb discussion here. doesn't really matter for this question specifically though!)

@Ryuno-Ki

This comment has been minimized.

Copy link
Owner Author

commented May 13, 2019

Okay, have just implemented endpoint discovery. Will check the behaviour of POSTs next. Thanks for the link!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.