Simplify the overriding of Trepn preferences #34
Conversation
| row = {key: value + float(new[key]) for key, value in list(accum.items()) if | ||
| key not in ['Component', 'count']} |
There was a problem hiding this comment.
This and the change below were autoformatted due to the lines being so long.
If prefered, I can undo these changes.
sshann
force-pushed
the
allow_setting_custom_preferences_in_trepn_profiler
branch
from
c2c37a7
to
2e18a15
Compare
|
I am doing a small change to allow to automatically override the remaining preferences without further changes in the source code |
This commit extends the overriding logic of Trepn preferences into a self-contained function, allowing users to override all configurations. Mirror the preferences key in the user-defined configuration to extend the overriding to any preference. To reduce the verbosity of the key, the mirrored key contains only the substring after the last dot. For instance, the preference `com.quicinc.preferences.general.profiling_interval` is mapped into `profiling_interval`.
sshann
force-pushed
the
allow_setting_custom_preferences_in_trepn_profiler
branch
from
41d4ad3
to
2ee5e3c
Compare
|
Looks good, but can you also update the relevant example configurations that use Trepn in |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Native and web examples are updated. |
|
By the way, wouldn't it be nicer to have the Trepn and the Android profiler in their own directory? |
Yes, I think you're right - they were the first. It makes sense to separate them. |
sshann
deleted the
allow_setting_custom_preferences_in_trepn_profiler
branch
PR S2-group#34 updates the Trepn profiler and allows overriding any preference. This caused a unit test to break as the PR updates the configuration file and replaces `sampligin_profiling` attribute by a map of preferences. This should have been notified in the PR itself.
PR S2-group#34 updates the Trepn profiler and allows overriding any preference. This caused a unit test to break as the PR updates the configuration file and replaces `sample_interval` attribute by a map of preferences. This should have been notified in the PR itself.
…rences_in_trepn_profiler Simplify the overriding of Trepn preferences
PR S2-group#34 updates the Trepn profiler and allows overriding any preference. This caused a unit test to break as the PR updates the configuration file and replaces `sample_interval` attribute by a map of preferences. This should have been notified in the PR itself.
Added android-runner
This commit extends the overriding logic of Trepn preferences into a self-contained function, allowing users to override all configurations. Mirror the preferences key in the user-defined configuration to extend the overriding to any preference. To reduce the verbosity of the key, the mirrored key contains only the substring after the last dot. For instance, the preference
com.quicinc.preferences.general.profiling_intervalis mapped intoprofiling_interval.