From 67a5d4efdbcd762a7eac304d7d3ddbdd076cefb0 Mon Sep 17 00:00:00 2001 From: Mark Jacobson <52427991+marksparkza@users.noreply.github.com> Date: Tue, 9 Apr 2024 16:04:24 +0200 Subject: [PATCH] Implement package deletion --- odp/api/routers/package.py | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/odp/api/routers/package.py b/odp/api/routers/package.py index fce0b24..7d410a3 100644 --- a/odp/api/routers/package.py +++ b/odp/api/routers/package.py @@ -3,7 +3,8 @@ from fastapi import APIRouter, Depends, HTTPException from jschon import JSONSchema from sqlalchemy import select -from starlette.status import HTTP_404_NOT_FOUND +from sqlalchemy.exc import IntegrityError +from starlette.status import HTTP_404_NOT_FOUND, HTTP_422_UNPROCESSABLE_ENTITY from odp.api.lib.auth import Authorize, Authorized from odp.api.lib.paging import Page, Paginator @@ -147,3 +148,23 @@ async def update_package( package.save() return output_package_model(package) + + +@router.delete( + '/{package_id}', +) +async def delete_package( + package_id: str, + auth: Authorized = Depends(Authorize(ODPScope.PACKAGE_WRITE)), +): + if not (package := Session.get(Package, package_id)): + raise HTTPException(HTTP_404_NOT_FOUND) + + auth.enforce_constraint([package.provider_id]) + + try: + package.delete() + except IntegrityError as e: + raise HTTPException( + HTTP_422_UNPROCESSABLE_ENTITY, 'A package cannot be deleted if it is associated with a record.' + ) from e