Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote assessment #283

Merged
merged 16 commits into from Aug 29, 2017
Merged

Remote assessment #283

merged 16 commits into from Aug 29, 2017

Conversation

@florianap
Copy link
Contributor

@florianap florianap commented Aug 22, 2017

No description provided.

@florianap
Copy link
Contributor Author

@florianap florianap commented Aug 22, 2017

Added remote assessment exercise for network mapping and device assessment

@joncamfield
Copy link
Contributor

@joncamfield joncamfield commented Aug 25, 2017

A few (ok, a lot) stylistic requests, because I gave bad guidance on file templates. I will work to adapt the network mapping pieces into the exercise format. Please note that the actual content here is fantastic, many thanks for the hard work and testing your team did to put this together.

One content request:

  • In operational_security.md , please consider adding points on having a secure communication channel via a different device than the one being rebooted into a live environment for support/debugging/making sure they don't press "install" and format their machine, and the importance of transferring the ssh commands over secure channels, acquiring the image over TLS (and checking signatures?), and using an updated, secured, or updated and ephemeral server for the middle connection.

Formatting/file requests:

  • Add an index.md file, change the "name" of this activity (from "Activity Title"), but otherwise a copy of this: https://github.com/SAFETAG/SAFETAG/blob/master/en/templates/folders/activity/index.md
  • Activity title is h4 (####) and the sub-titles are h5, so please constrain in-document section titles to h6 and bold (I know, bold isn't correct for semantic header usage 😢 )
  • Remove the activities.md file - I will link this activity in to the master guide index once merged.
  • Rename approaches.md to approach.md
  • Remove guiding_questions.md - this is used at the methodology level, not the activity level (mea culpa!)
  • Update materials_needed.md needed to h6 headers
  • We don't use output.md in the generated content any more, consider moving the information there to summary.md
  • We also don't use preparation.md, consider moving that to materials_needed.md?
  • Update walkthrough to h6 formatting. Once merged, I may also format it a bit further or edit for clarity, but amazing work.
@joncamfield
Copy link
Contributor

@joncamfield joncamfield commented Aug 29, 2017

Thank you for not only a great option to adapt this work remotely, but for such a quick turn-around on comments!

@joncamfield
Copy link
Contributor

@joncamfield joncamfield commented Aug 29, 2017

I've made some last tweaks to get the title in and the file linked in to the broader SAFETAG index files.

@joncamfield joncamfield merged commit d8c9557 into SAFETAG:master Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.