Skip to content
This repository has been archived by the owner. It is now read-only.

Running axioms forward chaining generates different result set from triples inference. #10

Closed
GezimSejdiu opened this issue Jan 8, 2019 · 4 comments

Comments

@GezimSejdiu
Copy link
Member

@GezimSejdiu GezimSejdiu commented Jan 8, 2019

While creating the axioms inference example I noticed that the result set is different from the one implemented on triples inference example.
Instead of returning inferred graph, it just returns the inferred axioms. Is there a reason behind it? Shall we consider being consistent in both cases?

Best regards,

@Hebaallahibrahim
Copy link
Member

@Hebaallahibrahim Hebaallahibrahim commented Jan 9, 2019

Hi Gezim, thanks for your notice. I changed it to return the inferred Graph.

Loading

@Hebaallahibrahim
Copy link
Member

@Hebaallahibrahim Hebaallahibrahim commented May 27, 2019

Hi @GezimSejdiu, Can we merge the PR updates and close this issue?

Loading

@GezimSejdiu
Copy link
Member Author

@GezimSejdiu GezimSejdiu commented May 28, 2019

Hi @Hebaallahibrahim ,
PR #11 needs at least one approve from the assigned reviewers. In this case, @patrickwestphal is the reviewer. Let's wait from him and then when the PR is approved we can close the issue.

Best,

Loading

@GezimSejdiu
Copy link
Member Author

@GezimSejdiu GezimSejdiu commented Jul 1, 2019

Resolved via #11

Loading

@GezimSejdiu GezimSejdiu closed this Jul 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants