This repository was archived by the owner on Oct 8, 2020. It is now read-only.
Refactor vandalism detection package #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no Spark or Flink involved on feature extraction, just string manipulation I moved them up to common layer in order to be able to be used by Spark or Flink module in the future
|
Hello @GezimSejdiu |
dgraux
approved these changes
Jan 8, 2019
There was a problem hiding this comment.
Hey @GezimSejdiu
Thank you very much for your contribution! Indeed, having a common layer for feature extractions is really an interesting factorization.
I approve these changes for a merge. 👍
|
Hi @dgraux , Best, |
dgraux
approved these changes
Jan 9, 2019
There was a problem hiding this comment.
Hi @GezimSejdiu
Thank you very much for the unit-test addition.
These are being deprecated since the same parser/reader do exist on the SANSA io. See here : https://github.com/SANSA-Stack/SANSA-RDF/tree/develop/sansa-rdf-spark/src/main/scala/net/sansa_stack/rdf/spark/io for more details
The TRIX RDF serialization format will be supported by SANSA-RDF io
It has been disabled as of now since the modeling the data (based on the input dataset) is taking longer. We are going to provide a smaller dataset which takes less time to run.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a cleanup and refactor the vandalism detection package. It introduces a common layer for feature extractions since it is done on the string manipulation only and can be used further by Spark and Flink module.
Best regards,