Skip to content
This repository was archived by the owner on Oct 8, 2020. It is now read-only.

Refactor vandalism detection package #12

Merged
merged 29 commits into from
Jan 23, 2019

Conversation

GezimSejdiu
Copy link
Member

This PR does a cleanup and refactor the vandalism detection package. It introduces a common layer for feature extractions since it is done on the string manipulation only and can be used further by Spark and Flink module.

Best regards,

@dgraux
Copy link
Member

dgraux commented Jan 8, 2019

Hello @GezimSejdiu
Thank you very much. Are you also considering adding a test SANSA-ML/sansa-ml-spark/src/test/scala/net/sansa_stack/ml/spark/outliers/?

Copy link
Member

@dgraux dgraux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GezimSejdiu
Thank you very much for your contribution! Indeed, having a common layer for feature extractions is really an interesting factorization.
I approve these changes for a merge. 👍

@GezimSejdiu
Copy link
Member Author

Hi @dgraux ,
indeed. Will consider adding basic unit-test for the vandalism detection methods.

Best,

Copy link
Member

@dgraux dgraux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GezimSejdiu
Thank you very much for the unit-test addition.

@GezimSejdiu GezimSejdiu merged commit 73350b2 into develop Jan 23, 2019
@GezimSejdiu GezimSejdiu deleted the feature/refactor-vandalismdetection-package branch January 23, 2019 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants