Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor vandalism detection package #12

Merged
merged 29 commits into from Jan 23, 2019

Conversation

@GezimSejdiu
Copy link
Member

commented Jan 8, 2019

This PR does a cleanup and refactor the vandalism detection package. It introduces a common layer for feature extractions since it is done on the string manipulation only and can be used further by Spark and Flink module.

Best regards,

@GezimSejdiu GezimSejdiu requested review from dgraux and HajiraJabeen Jan 8, 2019

@dgraux

This comment has been minimized.

Copy link
Member

commented Jan 8, 2019

Hello @GezimSejdiu
Thank you very much. Are you also considering adding a test SANSA-ML/sansa-ml-spark/src/test/scala/net/sansa_stack/ml/spark/outliers/?

@dgraux

dgraux approved these changes Jan 8, 2019

Copy link
Member

left a comment

Hey @GezimSejdiu
Thank you very much for your contribution! Indeed, having a common layer for feature extractions is really an interesting factorization.
I approve these changes for a merge. 👍

@GezimSejdiu

This comment has been minimized.

Copy link
Member Author

commented Jan 8, 2019

Hi @dgraux ,
indeed. Will consider adding basic unit-test for the vandalism detection methods.

Best,

@dgraux

dgraux approved these changes Jan 9, 2019

Copy link
Member

left a comment

Hi @GezimSejdiu
Thank you very much for the unit-test addition.

GezimSejdiu added some commits Jan 23, 2019

Add a running vandalism detection workflow.
It has been disabled as of now since the modeling the data (based on the input dataset) is taking longer.
We are going to provide a smaller dataset which takes less time to run.

@GezimSejdiu GezimSejdiu merged commit 73350b2 into develop Jan 23, 2019

4 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@GezimSejdiu GezimSejdiu deleted the feature/refactor-vandalismdetection-package branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.