Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: semantic query engine #30

Merged
merged 5 commits into from Apr 3, 2019

Conversation

@GezimSejdiu
Copy link
Member

commented Apr 3, 2019

Hi SANSA Query team,

this hot fix resolves the issue of not returning the result set when we run SPARQL queries over Semantic-based query engine implemented into SANSA.

This PR fixes issue #22 and partially issue #23
Regarding issue #23, the query posted there contains variable into BGP (?s ?p ?o), therefore, it is not supported by the semantic query engine (yet).
We plan to work on it when we plug-in our approach using the Jena ARQ API.

Best regards,

GezimSejdiu added some commits Apr 3, 2019

Fix semantic query-engine approach.
The system wasn't returning any result due to missing return RDD value with the result set.
This fixes #22 and partially the issue #23.
The query posted at the issue #23 contains variable into BGP, therefore, it is not supported by the semanic query engine (yet).
We plan to work on it when we plug-in our approach using the Jena ARQ api

@GezimSejdiu GezimSejdiu requested a review from dgraux Apr 3, 2019

@dgraux

dgraux approved these changes Apr 3, 2019

Copy link
Member

left a comment

Hi @GezimSejdiu
Thanks a lot for taking the time to do that 👍
(and kudos for also covering the test cases!!)

@GezimSejdiu GezimSejdiu merged commit 4f27a9a into develop Apr 3, 2019

4 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@GezimSejdiu GezimSejdiu deleted the hotfix/semantic-query-engine branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.