New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature of net.sansa_stack.rdf.spark.partition.semantic.RdfPartition not clear #68

Closed
patrickwestphal opened this Issue Oct 26, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@patrickwestphal
Copy link
Member

patrickwestphal commented Oct 26, 2018

To instantiate RdfPartition one has to pass the parameter partitionedDataPath which is not explained, nor used anywhere. It is also used in the SANSA-Examples without further explanation. Wondering whether it could be dropped.

@GezimSejdiu

This comment has been minimized.

Copy link
Member

GezimSejdiu commented Oct 29, 2018

Hi @patrickwestphal ,

many thanks for the question! Indeed, we could drop it as it is not needed on our implementation. It was there and used by Imran just for some evaluation after I guided him to get rid of the partitioning paths. I will remove it from the original code and update SANSA-Examples accordingly.

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment