New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/rdf parser #47

Merged
merged 5 commits into from Jun 4, 2018

Conversation

Projects
None yet
2 participants
@LorenzBuehmann
Copy link
Member

LorenzBuehmann commented Jun 4, 2018

Fixes SCalatestissues and RDF parsing bug.

@LorenzBuehmann LorenzBuehmann requested a review from SimonBin Jun 4, 2018

@LorenzBuehmann

This comment has been minimized.

Copy link
Member Author

LorenzBuehmann commented Jun 4, 2018

Ok, looks like the first time Scalatests are executed for the RDF layer...

@Aklakan
It looks like Travis fails because the SparqlifyPartitionTests fail with

partitioning N-Triples file into Sparqlify Partition (Vertical Partition) should result in size 30 *** FAILED ***
  25 did not equal 30 (SparqlifyPartitionTests.scala:22)

Actually, it should be 21 + x (x because of different literal datatypes) because

> awk '{print $2}' src/test/resources/rdf.nt | sort | uniq | wc -l
> 21

i.e., there are 21 distinct properties some of them used in triples with literal objects having multiple datatypes.

LorenzBuehmann added some commits Jun 4, 2018

@LorenzBuehmann LorenzBuehmann merged commit 1916bb1 into develop Jun 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@LorenzBuehmann LorenzBuehmann deleted the hotfix/rdf-parser branch Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment