Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sortBy operation for semantic-based partition. #80

Merged
merged 1 commit into from Apr 30, 2019

Conversation

@GezimSejdiu
Copy link
Member

commented Apr 30, 2019

It was causing shuffling overhead, therefore some of the queries weren't able to be evaluated when running on the cluster mode.
The sortBy operator was optional, therefore removing it will not impact the query result set.

Remove sortBy operation for semantic-based partition.
It was causing shuffling overhead, therefore some of the queries weren't able to be evaluated when running on the cluster mode.
The sortBy operator was optional, therefore removing it will not impact the query result set.

@GezimSejdiu GezimSejdiu requested a review from dgraux Apr 30, 2019

@coveralls

This comment has been minimized.

Copy link

commented Apr 30, 2019

Pull Request Test Coverage Report for Build 195

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 29.5%

Totals Coverage Status
Change from base Build 191: -0.02%
Covered Lines: 1252
Relevant Lines: 4244

💛 - Coveralls
@dgraux

dgraux approved these changes Apr 30, 2019

Copy link
Member

left a comment

Hi @GezimSejdiu
Thanks for spotting that indeed!
Cheers.

@GezimSejdiu GezimSejdiu merged commit 400c3a4 into develop Apr 30, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@GezimSejdiu GezimSejdiu deleted the fix/remove-sortBy-semantic-partition branch Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.