Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/increase test coverage #82

Merged
merged 41 commits into from Jun 7, 2019
Merged

Conversation

@GezimSejdiu
Copy link
Member

@GezimSejdiu GezimSejdiu commented Jun 6, 2019

This PR increases the coverage to 34% and does some other implementation (e.g. alignment of Flink implementation of quality assessment with the ones implemented in Spark, rdf tensor representation) and further cleanups and refactoring of Flink module.

Best regards,

GezimSejdiu added 30 commits Mar 15, 2019
Add export graph to Json method to the GraphOps instead.
We moved it to the common module as it can be used by Spark and Flink
It can be also used by the Flink module.
@GezimSejdiu GezimSejdiu added the RDF label Jun 6, 2019
@GezimSejdiu GezimSejdiu added this to the 0.6 milestone Jun 6, 2019
@GezimSejdiu GezimSejdiu requested a review from dgraux Jun 6, 2019
@coveralls
Copy link

@coveralls coveralls commented Jun 6, 2019

Pull Request Test Coverage Report for Build 210

  • 68 of 212 (32.08%) changed or added relevant lines in 20 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+4.3%) to 34.082%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sansa-rdf-flink/src/main/scala/net/sansa_stack/rdf/flink/qualityassessment/metrics/completeness/InterlinkingCompleteness.scala 0 1 0.0%
sansa-rdf-flink/src/main/scala/net/sansa_stack/rdf/flink/qualityassessment/metrics/completeness/PropertyCompleteness.scala 0 1 0.0%
sansa-rdf-flink/src/main/scala/net/sansa_stack/rdf/flink/qualityassessment/metrics/completeness/SchemaCompleteness.scala 0 1 0.0%
sansa-rdf-flink/src/main/scala/net/sansa_stack/rdf/flink/qualityassessment/metrics/licensing/MachineReadableLicense.scala 0 4 0.0%
sansa-rdf-flink/src/main/scala/net/sansa_stack/rdf/flink/stats/RDFStatistics.scala 1 5 20.0%
sansa-rdf-flink/src/main/scala/net/sansa_stack/rdf/flink/qualityassessment/metrics/licensing/HumanReadableLicense.scala 0 6 0.0%
sansa-rdf-flink/src/main/scala/net/sansa_stack/rdf/flink/qualityassessment/metrics/relevancy/CoverageDetail.scala 0 7 0.0%
sansa-rdf-spark/src/main/scala/net/sansa_stack/rdf/spark/model/package.scala 18 26 69.23%
sansa-rdf-flink/src/main/scala/net/sansa_stack/rdf/flink/qualityassessment/metrics/relevancy/CoverageScope.scala 0 9 0.0%
sansa-rdf-flink/src/main/scala/net/sansa_stack/rdf/flink/qualityassessment/metrics/reprconciseness/QueryParamFreeURIs.scala 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
sansa-rdf-flink/src/main/scala/net/sansa_stack/rdf/flink/qualityassessment/metrics/completeness/InterlinkingCompleteness.scala 1 0.0%
sansa-rdf-flink/src/main/scala/net/sansa_stack/rdf/flink/qualityassessment/metrics/syntacticvalidity/XSDDatatypeCompatibleLiterals.scala 1 0.0%
sansa-rdf-flink/src/main/scala/net/sansa_stack/rdf/flink/stats/RDFStatistics.scala 1 3.7%
Totals Coverage Status
Change from base Build 207: 4.3%
Covered Lines: 1488
Relevant Lines: 4366

💛 - Coveralls

Loading

dgraux
dgraux approved these changes Jun 6, 2019
Copy link
Member

@dgraux dgraux left a comment

Hi @GezimSejdiu
Wow that's a lot of contribution! 👍
Thank you… 😺

Loading

@GezimSejdiu GezimSejdiu merged commit bd012ea into develop Jun 7, 2019
2 checks passed
Loading
@GezimSejdiu GezimSejdiu deleted the feature/increase-test-coverage branch Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants