Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TRIX reader #83

Merged
merged 2 commits into from Jun 7, 2019
Merged

Conversation

@GezimSejdiu
Copy link
Member

@GezimSejdiu GezimSejdiu commented Jun 7, 2019

No description provided.

@GezimSejdiu GezimSejdiu added the RDF label Jun 7, 2019
@GezimSejdiu GezimSejdiu added this to the 0.6 milestone Jun 7, 2019
@GezimSejdiu GezimSejdiu requested a review from dgraux Jun 7, 2019
@coveralls
Copy link

@coveralls coveralls commented Jun 7, 2019

Pull Request Test Coverage Report for Build 219

  • 9 of 15 (60.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 34.217%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sansa-rdf-spark/src/main/scala/net/sansa_stack/rdf/spark/io/package.scala 9 15 60.0%
Files with Coverage Reduction New Missed Lines %
sansa-rdf-spark/src/main/scala/net/sansa_stack/rdf/spark/io/package.scala 1 64.29%
Totals Coverage Status
Change from base Build 217: 0.1%
Covered Lines: 1497
Relevant Lines: 4375

💛 - Coveralls

Loading

@GezimSejdiu GezimSejdiu requested a review from Aklakan Jun 7, 2019
Aklakan
Aklakan approved these changes Jun 7, 2019
Copy link
Member

@Aklakan Aklakan left a comment

There seems to be duplication in checks of format characters ('i', 'j', 'k', etc) which should be cleaned up eventually, but this shouldn't be a blocking issue.

Loading

@Aklakan Aklakan merged commit 0f68375 into develop Jun 7, 2019
2 checks passed
Loading
@GezimSejdiu GezimSejdiu deleted the feature/new-rdf-serialization-formats branch Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants