Permalink
Browse files

Patch for rails#1460

[3.1.0.rc1] Plugins inside engines not eager-loaded properly and their
rake tasks ignored

Working with the new support for plugins inside engines in Rails 3.1,
I found that certain things that work for regular plugins don't work
for these new nested plugins. In particular, these methods in
Rails::Engine don't seem to understand that an engine could have
nested plugins:

#load_tasks
#load_generators
#load_console
#eager_load!

A solution which worked out for me is to move the calls to
railties.all { ... } from the overriding methods in Rails::Application
into Rails::Engine.
  • Loading branch information...
1 parent 34d16e1 commit 27d7083addd1bc8ecf0ef258a50c5e36eb980060 @jhtwong jhtwong committed Jun 14, 2011
Showing with 14 additions and 9 deletions.
  1. +0 −8 railties/lib/rails/application.rb
  2. +14 −1 railties/lib/rails/engine.rb
@@ -78,10 +78,6 @@ def require_environment! #:nodoc:
require environment if environment
end
- def eager_load! #:nodoc:
- railties.all(&:eager_load!)
- super
- end
def reload_routes!
routes_reloader.reload!
@@ -100,22 +96,18 @@ def initialize!
def load_tasks(app=self)
initialize_tasks
- railties.all { |r| r.load_tasks(app) }
super
self
end
def load_generators(app=self)
initialize_generators
- railties.all { |r| r.load_generators(app) }
-
super
self
end
def load_console(app=self)
initialize_console
- railties.all { |r| r.load_console(app) }
super
self
end
@@ -387,12 +387,25 @@ def find(path)
delegate :middleware, :root, :paths, :to => :config
delegate :engine_name, :isolated?, :to => "self.class"
- def load_tasks(*)
+ def load_tasks(app=self)
+ railties.all { |r| r.load_tasks(app) }
super
paths["lib/tasks"].existent.sort.each { |ext| load(ext) }
end
+
+ def load_generators(app=self)
+ railties.all { |r| r.load_generators(app) }
+ super
+ end
+ def load_console(app=self)
+ railties.all { |r| r.load_console(app) }
+ super
+ end
+
def eager_load!
+ railties.all(&:eager_load!)
+
config.eager_load_paths.each do |load_path|
matcher = /\A#{Regexp.escape(load_path)}\/(.*)\.rb\Z/
Dir.glob("#{load_path}/**/*.rb").sort.each do |file|

0 comments on commit 27d7083

Please sign in to comment.